chore: remove src/types.ts from knip entry configuration
#353
Conversation
|
I believe knip is already recognizing |
|
Sorry, I meant this knip issue: https://github.com/eslint/rewrite/actions/runs/20762026304/job/59619177443 |
That's the same error. It will no longer appear now that |
Pixel998
changed the title
src/types.ts to knip entry configurationsrc/types.ts from knip entry configuration
|
You're right. My point was that knip needs explicit re-exports to avoid flagging types. I originally opened this PR thinking we'd need a structural fix (like Since we've gone with the re-export approach instead, these configuration entries are no longer needed. I've updated the PR to remove all of them. |
Prerequisites checklist
What is the purpose of this pull request?
This PR configures knip to properly recognize public API types in
src/types.tsfiles so they aren't incorrectly flagged as unused exports. These types are meant for external consumption by package users, even if they're not used internally within our codebase.What changes did you make? (Give an overview)
Added
src/types.tsto the knip entry configuration for four packages that export public types:@eslint/config-array@eslint/config-helpers@eslint/migrate-config@eslint/plugin-kitThe
@eslint/object-schemapackage already had this configuration.Related Issues
#351
Is there anything you'd like reviewers to focus on?